hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6617) ReplicationSourceManager should be able to track multiple WAL paths
Date Mon, 24 Aug 2015 17:50:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709716#comment-14709716
] 

Yu Li commented on HBASE-6617:
------------------------------

Maybe I'm wrong, but from the current code in ReplicationSourceManager#addSource:
{code}
    synchronized (this.walsById) {
      this.sources.add(src);
      this.walsById.put(id, new TreeSet<String>());
      // Add the latest wal to that source's queue
      if (this.latestPath != null) {
        String name = this.latestPath.getName();
        this.walsById.get(id).add(name);
      ...
{code}
I think it's simply sorting the log files by their names, but since there's only one logPrefix
for a single regionserver by default, all files in this set is with the same name prefix,
thus making the System.currentTimeMillis deciding the order?

> ReplicationSourceManager should be able to track multiple WAL paths
> -------------------------------------------------------------------
>
>                 Key: HBASE-6617
>                 URL: https://issues.apache.org/jira/browse/HBASE-6617
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Ted Yu
>            Assignee: Sean Busbey
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-6617.patch
>
>
> Currently ReplicationSourceManager uses logRolled() to receive notification about new
HLog and remembers it in latestPath.
> When region server has multiple WAL support, we need to keep track of multiple Path's
in ReplicationSourceManager



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message