Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 28 Jul 2015 17:23:06 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12849375.1438016419000.309190.1438104186243@Atlassian.JIRA>
In-Reply-To: <JIRA.12849375.1438016419000@Atlassian.JIRA>
References: <JIRA.12849375.1438016419000@Atlassian.JIRA>
 <JIRA.12849375.1438016419612@arcas>
Subject: [jira] [Commented] (HBASE-14157) Interfaces implemented by
 subclasses should be checked when registering CoprocessorService
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644686#comment-14644686 ] 

Hadoop QA commented on HBASE-14157:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12747568/14157-v4.txt
  against master branch at commit 89d04094626abebf279e9f64d597a7085bfc8fcf.
  ATTACHMENT ID: 12747568

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestDistributedLogSplitting

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14911//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14911//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14911//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14911//console

This message is automatically generated.

> Interfaces implemented by subclasses should be checked when registering CoprocessorService
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14157
>                 URL: https://issues.apache.org/jira/browse/HBASE-14157
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Alok Lal
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 1.2.0, 1.1.2, 1.3.0
>
>         Attachments: 14157-v1.txt, 14157-v2.txt, 14157-v2.txt, 14157-v3.txt, 14157-v4.txt
>
>
> Alok reported seeing the following exception when subclass of class which implements CoprocessorService is used for hbase.coprocessor.region.classes :
> {code}
> hbase(main):015:0> grant 'mktg1', 'RWC', 'iemployee'
> ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No registered coprocessor service found for name AccessControlService in region hbase:acl,,1437137157604.2daf735ea38da95e9ba249db6b63b79c.
>         at org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:7367)
>         at org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1873)
>         at org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1855)
>         at org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32209)
>         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2112)
>         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:101)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
> {code}
> The root cause is in the following code of RegionCoprocessorHost:
> {code}
>     for (Class<?> c : implClass.getInterfaces()) {
>       if (CoprocessorService.class.isAssignableFrom(c)) {
>         region.registerService( ((CoprocessorService)instance).getService() );
>       }
>     }
> {code}
> We currently only check the interfaces directly implemented by the underlying class.
> What should be done is to check all the interfaces implemented by class itself and its superclasses.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)