Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE99518B67 for ; Mon, 20 Jul 2015 11:51:04 +0000 (UTC) Received: (qmail 10469 invoked by uid 500); 20 Jul 2015 11:51:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 10422 invoked by uid 500); 20 Jul 2015 11:51:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10308 invoked by uid 99); 20 Jul 2015 11:51:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jul 2015 11:51:04 +0000 Date: Mon, 20 Jul 2015 11:51:04 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14099) StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633465#comment-14633465 ] ramkrishna.s.vasudevan commented on HBASE-14099: ------------------------------------------------ Let me check if I can reduce the createFirstDeleteFamilyOnRow also. I forgot about that. > StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row > --------------------------------------------------------------------------------------- > > Key: HBASE-14099 > URL: https://issues.apache.org/jira/browse/HBASE-14099 > Project: HBase > Issue Type: Bug > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14099.patch, HBASE-14099_1.patch, storefile.png > > > During profiling saw that the code here in passesKeyRangeFilter in Storefile > {code} > KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil > .createFirstOnRow(scan.getStopRow()) : KeyValueUtil.createFirstOnRow(scan > .getStartRow()); > KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil > .createLastOnRow(scan.getStartRow()) : KeyValueUtil.createLastOnRow(scan > .getStopRow()); > {code} > This row need not be copied now considering that we have CellComparator.compareRows(Cell, byte[]). > We have already refactored the firstKeyKv and lastKeyKV as part of other JIRAs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)