Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 86A6C18C3A for ; Thu, 16 Jul 2015 05:46:05 +0000 (UTC) Received: (qmail 1834 invoked by uid 500); 16 Jul 2015 05:46:05 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 1789 invoked by uid 500); 16 Jul 2015 05:46:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 1775 invoked by uid 99); 16 Jul 2015 05:46:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jul 2015 05:46:05 +0000 Date: Thu, 16 Jul 2015 05:46:05 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14089) Remove unnecessary draw of system entropy from RecoverableZooKeeper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629234#comment-14629234 ] Hudson commented on HBASE-14089: -------------------------------- FAILURE: Integrated in HBase-1.3 #59 (See [https://builds.apache.org/job/HBase-1.3/59/]) HBASE-14089 Remove unnecessary draw of system entropy from RecoverableZooKeeper (apurtell: rev c42fc1dd56a651a52b00d03833b00fb800fa5cd9) * hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java > Remove unnecessary draw of system entropy from RecoverableZooKeeper > ------------------------------------------------------------------- > > Key: HBASE-14089 > URL: https://issues.apache.org/jira/browse/HBASE-14089 > Project: HBase > Issue Type: Bug > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.1.2, 1.3.0, 1.2.1, 1.0.3 > > Attachments: HBASE-14089.patch > > > I had a look at instances where we use SecureRandom, which could block if insufficient entropy, in the 0.98 and master branch code. (Random in contrast is a PRNG seeded by System#nanoTime, it doesn't draw from system entropy.) Most uses are in encryption related code, our native encryption and SSL, but we do also use SecureRandom for salting znode metadata in RecoverableZooKeeper#appendMetadata, which is called whenever we do setData. Conceivably we could block unexpectedly when constructing data to write out to a znode if entropy gets too low until more is available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)