Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 269D218E70 for ; Wed, 15 Jul 2015 22:14:05 +0000 (UTC) Received: (qmail 11394 invoked by uid 500); 15 Jul 2015 22:14:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 11349 invoked by uid 500); 15 Jul 2015 22:14:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11335 invoked by uid 99); 15 Jul 2015 22:14:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2015 22:14:04 +0000 Date: Wed, 15 Jul 2015 22:14:04 +0000 (UTC) From: "Elliott Clark (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14089) Remove unnecessary draw of system entropy from RecoverableZooKeeper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628849#comment-14628849 ] Elliott Clark commented on HBASE-14089: --------------------------------------- I'm not a security professional but from what I've been advised it's basically never good for a application to use /dev/random. http://www.2uo.de/myths-about-urandom/ > Remove unnecessary draw of system entropy from RecoverableZooKeeper > ------------------------------------------------------------------- > > Key: HBASE-14089 > URL: https://issues.apache.org/jira/browse/HBASE-14089 > Project: HBase > Issue Type: Bug > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.1.2, 1.3.0, 1.0.3 > > Attachments: HBASE-14089.patch > > > I had a look at instances where we use SecureRandom, which could block if insufficient entropy, in the 0.98 and master branch code. (Random in contrast is a PRNG seeded by System#nanoTime, it doesn't draw from system entropy.) Most uses are in encryption related code, our native encryption and SSL, but we do also use SecureRandom for salting znode metadata in RecoverableZooKeeper#appendMetadata, which is called whenever we do setData. Conceivably we could block unexpectedly when constructing data to write out to a znode if entropy gets too low until more is available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)