Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F1587188D3 for ; Wed, 15 Jul 2015 20:07:04 +0000 (UTC) Received: (qmail 78388 invoked by uid 500); 15 Jul 2015 20:07:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 78333 invoked by uid 500); 15 Jul 2015 20:07:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 78320 invoked by uid 99); 15 Jul 2015 20:07:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2015 20:07:04 +0000 Date: Wed, 15 Jul 2015 20:07:04 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14082) Add replica id to JMX metrics names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628640#comment-14628640 ] Ted Yu commented on HBASE-14082: -------------------------------- Can we consider the following format ? namespace__table__region__metric__replicaid_ The goal is to keep backward compatibility so that TestMetricsRegion doesn't need to be modified. > Add replica id to JMX metrics names > ----------------------------------- > > Key: HBASE-14082 > URL: https://issues.apache.org/jira/browse/HBASE-14082 > Project: HBase > Issue Type: Improvement > Components: metrics > Reporter: Lei Chen > Assignee: Lei Chen > Attachments: HBASE-14082-v1.patch > > > Today, via JMX, one cannot distinguish a primary region from a replica. A possible solution is to add replica id to JMX metrics names. The benefits may include, for example: > # Knowing the latency of a read request on a replica region means the first attempt to the primary region has timeout. > # Write requests on replicas are due to the replication process, while the ones on primary are from clients. > # In case of looking for hot spots of read operations, replicas should be excluded since TIMELINE reads are sent to all replicas. > To implement, we can change the format of metrics names found at {code}Hadoop->HBase->RegionServer->Regions->Attributes{code} > from > {code}namespace__table__region__metric_{code} > to > {code}namespace__table__region__replicaid__metric_{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)