Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 82FAE1877D for ; Thu, 9 Jul 2015 18:23:06 +0000 (UTC) Received: (qmail 95590 invoked by uid 500); 9 Jul 2015 18:23:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 95545 invoked by uid 500); 9 Jul 2015 18:23:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95528 invoked by uid 99); 9 Jul 2015 18:23:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 18:23:06 +0000 Date: Thu, 9 Jul 2015 18:23:06 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HBASE-14049) SnapshotHFileCleaner should optionally clean up after failed snapshots MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620982#comment-14620982 ] Matteo Bertozzi edited comment on HBASE-14049 at 7/9/15 6:22 PM: ----------------------------------------------------------------- unfortunately the cleaner logic is completely separate from the snapshot manager or export/import. so you don't really know in the cleaner if that tmp dir is a failed snapshot or an in-progress one. (proc-v2 should solve this problem) also everyone should already clean tmp after failure, if they don't do it is because hdfs was not responding and we got an exception (on master restart or attemp to take a snapshot with the same name that dir will be cleaned) or there is a bug in that part of the code. https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java#L219 https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java#L963 was (Author: mbertozzi): unfortunately the cleaner logic is completely separate from the snapshot manager or export/import. so you don't really know in the cleaner if that tmp dir is a failed snapshot or an in-progress one. also everyone should already clean tmp after failure, if they don't do it is because hdfs was not responding and we got an exception (on master restart or attemp to take a snapshot with the same name that dir will be cleaned) or there is a bug in that part of the code. https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java#L219 https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java#L963 > SnapshotHFileCleaner should optionally clean up after failed snapshots > ---------------------------------------------------------------------- > > Key: HBASE-14049 > URL: https://issues.apache.org/jira/browse/HBASE-14049 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.13 > Reporter: Andrew Purtell > > SnapshotHFileCleaner should optionally clean up after failed snapshots rather than just complain. Add a configuration option that, if set to true (defaulting to false), instructs SnapshotHFileCleaner to recursively remove failed snapshot temporary directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)