Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 10 Jul 2015 19:24:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12841503.1435623788000.157990.1436556245679@Atlassian.JIRA>
In-Reply-To: <JIRA.12841503.1435623788000@Atlassian.JIRA>
References: <JIRA.12841503.1435623788000@Atlassian.JIRA>
 <JIRA.12841503.1435623788392@arcas>
Subject: [jira] [Commented] (HBASE-13993) WALProcedureStore fencing is not
 effective if new WAL rolls
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622793#comment-14622793 ] 

Hadoop QA commented on HBASE-13993:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12744744/HBASE-13993-v3.patch
  against master branch at commit bff911a8e894f59f6efe6a24f39a7aef5d689882.
  ATTACHMENT ID: 12744744

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14739//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14739//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14739//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14739//console

This message is automatically generated.

> WALProcedureStore fencing is not effective if new WAL rolls 
> ------------------------------------------------------------
>
>                 Key: HBASE-13993
>                 URL: https://issues.apache.org/jira/browse/HBASE-13993
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.1.2, 1.3.0, 1.2.1
>
>         Attachments: HBASE-13993-v2.patch, HBASE-13993-v3.patch, hbase-13993_v1.patch
>
>
> WAL fencing for the WALProcedureStore is a bit different than the fencing done for region server WALs. 
> In case of this sequence of events, the WAL is not fenced (especially with HBASE-13832 patch): 
>  - master1 creates WAL with logId = 1: {{/MasterProcWALs/state-00000000000000000001.log}} 
>  - master2 takes over, fences logId = 1 with recoverLease(), creates logId=2: {{/MasterProcWALs/state-00000000000000000002.log}}.
>  - master2 writes some procedures and rolls the logId2, and creates logId = 3, and deletes logId = 2. 
>  - master1 now tries to write a procedure, gets lease mismatch, rolls the log from 1 to 2, and succeeds the write since it can write logId = 2 (master2 uses logId=3 now). 
>  


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)