Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08144181EC for ; Sat, 18 Jul 2015 18:40:05 +0000 (UTC) Received: (qmail 76707 invoked by uid 500); 18 Jul 2015 18:40:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 76655 invoked by uid 500); 18 Jul 2015 18:40:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 76640 invoked by uid 99); 18 Jul 2015 18:40:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Jul 2015 18:40:04 +0000 Date: Sat, 18 Jul 2015 18:40:04 +0000 (UTC) From: "Gabor Liptak (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13981) Fix ImportTsv spelling and usage issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632562#comment-14632562 ] Gabor Liptak commented on HBASE-13981: -------------------------------------- [~ashish singhi] I might have missed something, but seem to be no references to ATTRIBUTE_SEPERATOR_CONF_KEY or to "attributes.seperator" in the HBASE codebase. So deprecating and removing doesn't represent a functional change. If we so deem, I'm happy to update the patch with a rename. > Fix ImportTsv spelling and usage issues > --------------------------------------- > > Key: HBASE-13981 > URL: https://issues.apache.org/jira/browse/HBASE-13981 > Project: HBase > Issue Type: Bug > Components: mapreduce > Affects Versions: 1.1.0.1 > Reporter: Lars George > Assignee: Gabor Liptak > Labels: beginner > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-13981.1.patch, HBASE-13981.2.patch, HBASE-13981.3.patch, HBASE-13981.4.patch > > > The {{ImportTsv}} tool has various spelling and formatting issues. Fix those. > In code: > {noformat} > public final static String ATTRIBUTE_SEPERATOR_CONF_KEY = "attributes.seperator"; > {noformat} > It is "separator". > In usage text: > {noformat} > "input data. Another special columnHBASE_TS_KEY designates that this column should be" > {noformat} > Space missing. > {noformat} > "Record with invalid timestamps (blank, non-numeric) will be treated as bad record." > {noformat} > "Records ... as bad records" - plural missing twice. > {noformat} > "HBASE_ATTRIBUTES_KEY can be used to specify Operation Attributes per record. > Should be specified as key=>value where -1 is used > as the seperator. Note that more than one OperationAttributes can be specified." > {noformat} > - Remove line wraps and indentation. > - Fix "separator". > - Fix wrong separator being output, it is not "-1" (wrong constant use in code) > - General wording/style could be better (eg. last sentence now uses OperationAttributes without a space). -- This message was sent by Atlassian JIRA (v6.3.4#6332)