Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 27 Jul 2015 22:42:05 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12840346.1435181985000.301897.1438036925123@Atlassian.JIRA>
In-Reply-To: <JIRA.12840346.1435181985000@Atlassian.JIRA>
References: <JIRA.12840346.1435181985000@Atlassian.JIRA>
 <JIRA.12840346.1435181985215@arcas>
Subject: [jira] [Commented] (HBASE-13965) Stochastic Load Balancer JMX
 Metrics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HBASE-13965?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D146=
43544#comment-14643544 ]=20

Ted Yu commented on HBASE-13965:
--------------------------------

{code}
+   * This constructor that accepts an instance of MetricsBalancer,
+   * which will be used instead of creating a new one
{code}
'This constructor' -> 'Constructor'
{code}
+  protected BaseLoadBalancer(MetricsBalancer metricsBalancer) {
+    if (metricsBalancer !=3D null)
+      this.metricsBalancer =3D metricsBalancer;
+    else
+      this.metricsBalancer =3D new MetricsBalancer();
{code}
Either put the assignment on the same line as if / else, or enclose assignm=
ent in curly braces.
{code}
+    } catch (Exception e) {
+      LOG.info("failed to get the size of all tables, exception =3D " + e.=
getMessage());
{code}
The above log should be at error level.


> Stochastic Load Balancer JMX Metrics
> ------------------------------------
>
>                 Key: HBASE-13965
>                 URL: https://issues.apache.org/jira/browse/HBASE-13965
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer, metrics
>            Reporter: Lei Chen
>            Assignee: Lei Chen
>         Attachments: HBASE-13965-v3.patch, HBASE-13965-v4.patch, HBASE-13=
965-v5.patch, HBASE-13965-v6.patch, HBASE-13965-v7.patch, HBASE-13965-v8.pa=
tch, HBASE-13965-v9.patch, HBASE-13965_v2.patch, HBase-13965-JConsole.png, =
HBase-13965-v1.patch, stochasticloadbalancerclasses_v2.png
>
>
> Today=E2=80=99s default HBase load balancer (the Stochastic load balancer=
) is cost function based. The cost function weights are tunable but no visi=
bility into those cost function results is directly provided.
> A driving example is a cluster we have been tuning which has skewed rack =
size (one rack has half the nodes of the other few racks). We are tuning th=
e cluster for uniform response time from all region servers with the abilit=
y to tolerate a rack failure. Balancing LocalityCost, RegionReplicaRack Cos=
t and RegionCountSkew Cost is difficult without a way to attribute each cos=
t function=E2=80=99s contribution to overall cost.=20
> What this jira proposes is to provide visibility via JMX into each cost f=
unction of the stochastic load balancer, as well as the overall cost of the=
 balancing plan.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)