Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C4A818A3B for ; Wed, 15 Jul 2015 15:30:06 +0000 (UTC) Received: (qmail 25910 invoked by uid 500); 15 Jul 2015 15:30:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 25864 invoked by uid 500); 15 Jul 2015 15:30:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 25850 invoked by uid 99); 15 Jul 2015 15:30:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2015 15:30:06 +0000 Date: Wed, 15 Jul 2015 15:30:06 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HBASE-12295) Prevent block eviction under us if reads are in progress from the BBs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628237#comment-14628237 ] Anoop Sam John edited comment on HBASE-12295 at 7/15/15 3:29 PM: ----------------------------------------------------------------- The new method hasTags to go in where? In read path we will deal with Cell type and we can add this to Cell interface. May be we can avoid 2 impls one with out tags and one with. Have a state (boolean) in Cell impl. We have SizeCachedKeyValue abd SizeCachedNoTagsKeyValue now. May be we will only have SizeCachedKeyValue and it will have a boolean state whether it has tags or not. The getTagsLength() can check this state ad return 0 or decode tags length. We have extra 6 bytes per cell in this SizeCachedKeyValue now. Make it 7 is ok IMO was (Author: anoop.hbase): The new method hasTags to go in where? In read path we will deal with Cell type and we can add this to Cell interface. May be we can avoid 2 impls one with out tags and one with. Have a state (boolean) in Cell impl. We have SizeCachedKeyValue abd SizeCachedNoTagsKeyValue now. May be we will only have SizeCachedKeyValue and it will have a boolean state whether it has tags or not. The getTagsLength() can check this state ad return 0 or decode tags length. We have extra 6 bytes per cell in this SizeCachedKeyValue now. Make it 7 is ok? > Prevent block eviction under us if reads are in progress from the BBs > --------------------------------------------------------------------- > > Key: HBASE-12295 > URL: https://issues.apache.org/jira/browse/HBASE-12295 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-12295.pdf, HBASE-12295_1.patch, HBASE-12295_1.pdf, HBASE-12295_10.patch, HBASE-12295_12.patch, HBASE-12295_14.patch, HBASE-12295_2.patch, HBASE-12295_4.patch, HBASE-12295_4.pdf, HBASE-12295_5.pdf, HBASE-12295_9.patch, HBASE-12295_trunk.patch > > > While we try to serve the reads from the BBs directly from the block cache, we need to ensure that the blocks does not get evicted under us while reading. This JIRA is to discuss and implement a strategy for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)