hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apekshit Sharma (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-14127) Refactor AssignmentManager.unassign() function which has lots of return statements
Date Tue, 21 Jul 2015 09:03:05 GMT
Apekshit Sharma created HBASE-14127:
---------------------------------------

             Summary: Refactor AssignmentManager.unassign() function which has lots of return
statements
                 Key: HBASE-14127
                 URL: https://issues.apache.org/jira/browse/HBASE-14127
             Project: HBase
          Issue Type: Improvement
            Reporter: Apekshit Sharma
            Assignee: Apekshit Sharma
            Priority: Minor


In AssignmentManager.unassign()
* there are lots of return points
* if condition is very non-trivial to understand
* reuse of 'state' for different purpose makes things confusing

A simple unfold of if-else with with better variable names should be sufficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message