hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuhao Bi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14115) Fix resource leak in HMasterCommandLine
Date Wed, 22 Jul 2015 10:58:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636717#comment-14636717
] 

Yuhao Bi commented on HBASE-14115:
----------------------------------

You are right, adm.shutdown() is not in the finally block.
Here comes the patch.

Thanks.

> Fix resource leak in HMasterCommandLine
> ---------------------------------------
>
>                 Key: HBASE-14115
>                 URL: https://issues.apache.org/jira/browse/HBASE-14115
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Yuhao Bi
>            Assignee: Yuhao Bi
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14115-branch-1.patch, HBASE-14115.patch
>
>
> In HMasterCommandLine#stopMaster(), admin is not closed.
> {code:title=HMasterCommandLine.java|borderStyle=solid}
> try (Connection connection = ConnectionFactory.createConnection(conf)) {
>       try (Admin admin = connection.getAdmin()) {
>         connection.getAdmin().shutdown();
>       } catch (Throwable t) {
>         LOG.error("Failed to stop master", t);
>         return 1;
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message