hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14075) HBaseClusterManager should use port(if given) to find pid
Date Tue, 14 Jul 2015 22:50:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627218#comment-14627218

Hadoop QA commented on HBASE-14075:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit 2f327c911056d02813f642503db9a4383e8b4a2f.
  ATTACHMENT ID: 12745315

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 53 new or modified

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +    clusterManager.kill(ServiceType.HBASE_MASTER, serverName.getHostname(), serverName.getPort(),
+    execWithRetries(hostname, getCommandProvider(service).signalCommand(service, signal,
port, pid));

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14770//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14770//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14770//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14770//console

This message is automatically generated.

> HBaseClusterManager should use port(if given) to find pid
> ---------------------------------------------------------
>                 Key: HBASE-14075
>                 URL: https://issues.apache.org/jira/browse/HBASE-14075
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Minor
>         Attachments: HBASE-14075-master_v2.patch, HBASE-14075-master_v3.patch, HBASE-14075.patch
> This issue is found while we run ITBLL in distributed cluster. Our testing env is kind
of special that we run multiple regionserver instance on a single physical machine, so {noformat}ps
-ef | grep proc_regionserver{noformat} will return more than one line, thus cause the tool
might check/kill the wrong process
> Actually in HBaseClusterManager we already introduce port as a parameter for methods
like isRunning, kill, etc. So the only thing to do here is to get pid through port if port
is given

This message was sent by Atlassian JIRA

View raw message