hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14069) Add the ability for RegionSplitter to rolling split without using a SplitAlgorithm
Date Thu, 23 Jul 2015 19:30:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639390#comment-14639390
] 

Elliott Clark commented on HBASE-14069:
---------------------------------------

* You're doing a lot with start and end keys trying to keep them in a map. I don't think that
there's a need. Just look for a region with the start key of the parent region to come online
( child one). When you find that, look for another region (child two) with the start key of
that's the same as child one's end key. If those two regions come online then it's split.
* requiredRegionSize and requiredNumRegions aren't good names. They aren't required. They
are what is being requested. The sizes may or may not get there. The number may or may not
get there.
* configuration names should start with hbase.
* Sizes are usually specified in bytes unless the name says otherwise.
* splitAllRegions is a bad name. It's splitting regions that meet some guidelines.
* You're creating a lot of filesystems. Get one and keep it the whole time.
* {code}Pair<byte[][], byte[][]> tmp = null;{code} This could be named better.
* Line 507 seems wrong. There's no need for start and end keys to be the same length.
* Why have line 511?
* Why the magic numbers in the retry counter factory?



> Add the ability for RegionSplitter to rolling split without using a SplitAlgorithm
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-14069
>                 URL: https://issues.apache.org/jira/browse/HBASE-14069
>             Project: HBase
>          Issue Type: New Feature
>          Components: hbase, util
>            Reporter: Elliott Clark
>            Assignee: Abhilash
>         Attachments: 0001-Improve-RegionSplitter.patch
>
>
> RegionSplittler is the utility that can rolling split regions. It would be nice to be
able to split regions and have the normal split points get computed for me so that I'm not
reliant on knowing data distribution.
> Tested manually on standalone mode for various test cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message