hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14052) Mark a few methods in CellUtil audience private since only make sense internally to hbase
Date Fri, 10 Jul 2015 05:51:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621785#comment-14621785
] 

Anoop Sam John commented on HBASE-14052:
----------------------------------------

[~stack]   You missed my above comment.  +1 for V2 also.

{quote}
Same can be done for some more methods?
estimatedSerializedSizeOf
estimatedSerializedSizeOfKey
estimatedHeapSizeOf
setSequenceId
writeFlatKey
writeRowKeyExcludingCommon
findCommonPrefixInFlatKey
equalsIgnoreMvccVersion
Even this also?
getCellKeySerializedAsKeyValueKey
{quote}

> Mark a few methods in CellUtil audience private since only make sense internally to hbase
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-14052
>                 URL: https://issues.apache.org/jira/browse/HBASE-14052
>             Project: HBase
>          Issue Type: Task
>          Components: API
>    Affects Versions: 1.0.0
>            Reporter: stack
>            Assignee: stack
>            Priority: Trivial
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: 14052v2.txt, 14052v2.txt, 14502.txt, 14502.txt
>
>
> A few methods in CellUtil only make sense server-side. It is a bit late now but lets
mark them private just so give some indication that they are not for general consumption (comes
of reading Lars V2 of book)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message