hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-14049) SnapshotHFileCleaner should optionally clean up after failed snapshots
Date Thu, 09 Jul 2015 18:24:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620981#comment-14620981
] 

Andrew Purtell edited comment on HBASE-14049 at 7/9/15 6:23 PM:
----------------------------------------------------------------

After a HDFS level blip during snapshotting we typically see detritus missing .snapshotinfo,
or having one that is corrupt, leading to InvalidProtocolBufferException upon read attempt.
Today SnapshotHFileCleaner only warns and moves on:

{noformat}
2015-07-02 16:29:49,490 ERROR [archivedHFileCleaner] snapshot.SnapshotHFileCleaner -
Exception while checking if files were valid, keeping them just in case.
...
{noformat}

leading to a lot of log noise until the problem is manually addressed.

At a minimum that ERROR level logging should be reduced to WARN


was (Author: apurtell):
After a HDFS level blip during snapshotting we typically see detritus missing .snapshotinfo,
or having one that is corrupt, leading to InvalidProtocolBufferException upon read attempt.
Today SnapshotHFileCleaner only warns and moves on:

{noformat}
2015-07-02 16:29:49,490 ERROR [archivedHFileCleaner] snapshot.SnapshotHFileCleaner -
Exception while checking if files were valid, keeping them just in case.
...
{noformat}

leading to a lot of log noise until the problem is manually addressed.

> SnapshotHFileCleaner should optionally clean up after failed snapshots
> ----------------------------------------------------------------------
>
>                 Key: HBASE-14049
>                 URL: https://issues.apache.org/jira/browse/HBASE-14049
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.13
>            Reporter: Andrew Purtell
>
> SnapshotHFileCleaner should optionally clean up after failed snapshots rather than just
complain. Add a configuration option that, if set to true (defaulting to false), instructs
SnapshotHFileCleaner to recursively remove failed snapshot temporary directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message