hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-14049) SnapshotHFileCleaner should optionally clean up after failed snapshots
Date Thu, 09 Jul 2015 18:23:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620982#comment-14620982
] 

Matteo Bertozzi edited comment on HBASE-14049 at 7/9/15 6:22 PM:
-----------------------------------------------------------------

unfortunately the cleaner logic is completely separate from the snapshot manager or export/import.
so you don't really know in the cleaner if that tmp dir is a failed snapshot or an in-progress
one.
(proc-v2 should solve this problem)

also everyone should already clean tmp after failure, if they don't do it is because hdfs
was not responding and we got an exception (on master restart or attemp to take a snapshot
with the same name that dir will be cleaned) or there is a bug in that part of the code.
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java#L219
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java#L963


was (Author: mbertozzi):
unfortunately the cleaner logic is completely separate from the snapshot manager or export/import.
so you don't really know in the cleaner if that tmp dir is a failed snapshot or an in-progress
one.

also everyone should already clean tmp after failure, if they don't do it is because hdfs
was not responding and we got an exception (on master restart or attemp to take a snapshot
with the same name that dir will be cleaned) or there is a bug in that part of the code.
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java#L219
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java#L963

> SnapshotHFileCleaner should optionally clean up after failed snapshots
> ----------------------------------------------------------------------
>
>                 Key: HBASE-14049
>                 URL: https://issues.apache.org/jira/browse/HBASE-14049
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.13
>            Reporter: Andrew Purtell
>
> SnapshotHFileCleaner should optionally clean up after failed snapshots rather than just
complain. Add a configuration option that, if set to true (defaulting to false), instructs
SnapshotHFileCleaner to recursively remove failed snapshot temporary directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message