hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14030) HBase Backup/Restore Phase 1
Date Mon, 20 Jul 2015 23:57:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634304#comment-14634304
] 

Ted Yu commented on HBASE-14030:
--------------------------------

Vlad was asking about where the code duplication in composing table set string is.

In BackupContext :
{code}
+  public String getTableListAsString() {
+    StringBuilder sb = new StringBuilder();
+    for (String table : this.backupStatusMap.keySet()) {
+      sb.append(table + ";");
+    }
+    sb.deleteCharAt(sb.lastIndexOf(";"));
{code}
In BackupManifest :
{code}
+    for (String table : this.getTableSet()) {
+      sb.append(table + ";");
+    }
+    if (sb.length() > 1 && sb.charAt(sb.length() - 1) == ';') {
+      sb.deleteCharAt(sb.length() - 1);
+    }
{code}

> HBase Backup/Restore Phase 1
> ----------------------------
>
>                 Key: HBASE-14030
>                 URL: https://issues.apache.org/jira/browse/HBASE-14030
>             Project: HBase
>          Issue Type: Umbrella
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>         Attachments: HBASE-14030-v0.patch, HBASE-14030-v1.patch, HBASE-14030-v2.patch,
HBASE-14030-v3.patch, HBASE-14030-v4.patch, HBASE-14030-v5.patch
>
>
> This is the umbrella ticket for Backup/Restore Phase 1. See HBASE-7912 design doc for
the phase description.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message