hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13998) Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength)
Date Thu, 02 Jul 2015 07:13:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611581#comment-14611581
] 

Hudson commented on HBASE-13998:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #6624 (See [https://builds.apache.org/job/HBase-TRUNK/6624/])
HBASE-13998 Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[]
right, int roffset, int rlength). (anoopsamjohn: rev 62f56944919b436036dcac740d8a21c56289a164)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaCache.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/SyncTable.java
* hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java


> Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right,
int roffset, int rlength)
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13998
>                 URL: https://issues.apache.org/jira/browse/HBASE-13998
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13998.patch
>
>
> A public API in CellComparator which takes old style byte[], offset, length alone is
not correct.  CellComparator supposed to compare cell(s).  At least one side param has to
be a cell.. This is the agreement we discussed in HBASE-10800.  Still we could not remove
the above one method because it was getting used from multiple places.  Now most of the usage
is removed.  This jira aims at removing it fully and replace the usage with other APIs.
> Note: The CellComparator is added in 2.0 only so removing the public API is not creating
any BC issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message