hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13995) ServerName is not fully case insensitive
Date Wed, 01 Jul 2015 00:19:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609308#comment-14609308
] 

Hadoop QA commented on HBASE-13995:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12742946/HBASE-13995-v0.patch
  against master branch at commit 42d5ef017d3d629e6ca9ee93e15ac4f0f9e00ce1.
  ATTACHMENT ID: 12742946

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14630//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14630//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14630//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14630//console

This message is automatically generated.

> ServerName is not fully case insensitive
> ----------------------------------------
>
>                 Key: HBASE-13995
>                 URL: https://issues.apache.org/jira/browse/HBASE-13995
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 2.0.0, 1.2.0, 0.98.12.1, 1.0.1.1, 1.1.0.1
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
>
>         Attachments: HBASE-13995-v0.patch, HBASE-13995-v0.patch
>
>
> we ended up with two ServerName with different cases, AAA and aaa.
> Trying to create a table, every once in a while, we ended up with the region lost and
not assigned. 
> BaseLoadBalancer.roundRobinAssignment() goes through each server and create a map with
what to assign to them.
> We had to server on the list AAA and aaa which are the same machine, the problem is that
the round robin now is assigning an empty list to one of the two. so depending on the order
we ended up with a region not assigned.
> ServerName equals() does the case insensitive comparison but the hashCode() is done on
a case sensitive server name, so the Map in ServerManager will never hit the item and compare
it using equals, so we end up with two entries that are the same server. similar thing for
ServerName.isSameHostnameAndPort() where we don't check for cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message