hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13977) Convert getKey and related APIs to Cell
Date Thu, 02 Jul 2015 06:43:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611559#comment-14611559
] 

stack commented on HBASE-13977:
-------------------------------

What does this mean: "Gets the current key in the form of a cell." That there is no value
returned?

In getKeyAsCell, why bother with a ByteBuffer when all you are doing is passing an array?

getKeyAsCell is defined in multiple Interfaces? Can we avoid that?

Here we are creating a Cell every time:

          if (getComparator().compare(splitCell, getKeyAsCell()) <= 0) {

Previous we were passing current array, no allocation and no KeyValue creation (if I am reading
this right). Do we have to do this? Anything we can do better here?

Ditto in next hunk of changes.

Otherwise, I like these changes.


> Convert getKey and related APIs to Cell
> ---------------------------------------
>
>                 Key: HBASE-13977
>                 URL: https://issues.apache.org/jira/browse/HBASE-13977
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-13977.patch, HBASE-13977_1.patch, HBASE-13977_2.patch, HBASE-13977_3.patch
>
>
> During the course of changes for HBASE-11425 felt that more APIs can be converted to
return Cell instead of BB like getKey, getLastKey. 
> We can also rename the getKeyValue to getCell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message