hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singhi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13954) Remove HTableInterface#getRowOrBefore related server side code
Date Fri, 17 Jul 2015 18:43:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631726#comment-14631726
] 

Ashish Singhi commented on HBASE-13954:
---------------------------------------

Regarding thrift code.. I am facing some issue in installing thrift :( so for now I will create
a new jira and handle that. As it is not that major issue now because ThriftServerRunner#getRowOrBefore
is internally using reverse scan 
{code}
  private Result getRowOrBefore(byte[] tableName, byte[] row, byte[] family) throws IOException
{
      Scan scan = new Scan(row);
      scan.setReversed(true);
      scan.addFamily(family);
      scan.setStartRow(row);

      Table table = getTable(tableName);
      try (ResultScanner scanner = table.getScanner(scan)) {
        return scanner.next();
      }
    }
{code}
Only thing is, it is deprecated so should be removed which should not be a problem If I am
not able to do as part of this jira.

> Remove HTableInterface#getRowOrBefore related server side code
> --------------------------------------------------------------
>
>                 Key: HBASE-13954
>                 URL: https://issues.apache.org/jira/browse/HBASE-13954
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13954(1).patch, HBASE-13954-v1.patch, HBASE-13954-v2.patch,
HBASE-13954-v3.patch, HBASE-13954.patch
>
>
> As part of HBASE-13214 review, [~anoop.hbase] had a review comment on the review board
to remove all the server side related code for getRowOrBefore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message