hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13881) Bugs in HTable incrementColumnValue implementation
Date Tue, 21 Jul 2015 04:24:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634509#comment-14634509
] 

Hadoop QA commented on HBASE-13881:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12746238/HBASE-13881.branch-1.1.patch
  against branch-1.1 branch at commit 7ce318dd3be9df0ee1c025b4792ded0161aa2c9c.
  ATTACHMENT ID: 12746238

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14846//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14846//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14846//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14846//console

This message is automatically generated.

> Bugs in HTable incrementColumnValue implementation
> --------------------------------------------------
>
>                 Key: HBASE-13881
>                 URL: https://issues.apache.org/jira/browse/HBASE-13881
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.6.1, 1.0.1
>            Reporter: Jerry Lam
>         Attachments: HBASE-13881.branch-1.1.patch
>
>
> The exact method I'm talking about is:
> {code}
> @Deprecated
>   @Override
>   public long incrementColumnValue(final byte [] row, final byte [] family,
>       final byte [] qualifier, final long amount, final boolean writeToWAL)
>   throws IOException {
>     return incrementColumnValue(row, family, qualifier, amount,
>       writeToWAL? Durability.SKIP_WAL: Durability.USE_DEFAULT);
>   }
> {code}
> Setting writeToWAL to true, Durability will be set to SKIP_WAL which does not make much
sense unless the meaning of SKIP_WAL is negated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message