hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13646) HRegion#execService should not try to build incomplete messages
Date Mon, 06 Jul 2015 20:29:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615595#comment-14615595
] 

Hudson commented on HBASE-13646:
--------------------------------

FAILURE: Integrated in HBase-0.98 #1047 (See [https://builds.apache.org/job/HBase-0.98/1047/])
HBASE-13646 HRegion#execService should not try to build incomplete messages (busbey: rev 2353c1bcf7debcc90e1f6d47787404c42a9d53b0)
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java
* hbase-server/src/test/protobuf/DummyRegionServerEndpoint.proto
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
* hbase-server/pom.xml


> HRegion#execService should not try to build incomplete messages
> ---------------------------------------------------------------
>
>                 Key: HBASE-13646
>                 URL: https://issues.apache.org/jira/browse/HBASE-13646
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, regionserver
>    Affects Versions: 2.0.0, 1.2.0, 1.1.1
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>             Fix For: 2.0.0, 0.98.14, 1.2.0
>
>         Attachments: HBASE-13646-branch-1.patch, HBASE-13646.patch, HBASE-13646.v2.patch,
HBASE-13646.v2.patch
>
>
> If some RPC service, called on region throws exception, execService still tries to build
Message. In case of complex messages with required fields it complicates service code because
service need to pass fake protobuf objects, so they can be barely buildable. 
> To mitigate that I propose to check that controller was failed and return null from call
instead of failing with exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message