hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13646) HRegion#execService should not try to build incomplete messages
Date Mon, 06 Jul 2015 16:06:05 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Busbey updated HBASE-13646:
--------------------------------
      Resolution: Fixed
    Hadoop Flags: Incompatible change
    Release Note: When RegionServerCoprocessors throw an exception we will no longer attempt
to build an incomplete RPC response message. Instead, the response message will be null.
          Status: Resolved  (was: Patch Available)

pushed to branch-1, branch-1.2, and 0.98.

Added a release note about the change for coprocessors; would appreciate a quick review to
make sure it's correct.

> HRegion#execService should not try to build incomplete messages
> ---------------------------------------------------------------
>
>                 Key: HBASE-13646
>                 URL: https://issues.apache.org/jira/browse/HBASE-13646
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, regionserver
>    Affects Versions: 2.0.0, 1.2.0, 1.1.1
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>             Fix For: 2.0.0, 0.98.14, 1.2.0
>
>         Attachments: HBASE-13646-branch-1.patch, HBASE-13646.patch, HBASE-13646.v2.patch,
HBASE-13646.v2.patch
>
>
> If some RPC service, called on region throws exception, execService still tries to build
Message. In case of complex messages with required fields it complicates service code because
service need to pass fake protobuf objects, so they can be barely buildable. 
> To mitigate that I propose to check that controller was failed and return null from call
instead of failing with exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message