hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13561) ITBLL.Verify doesn't actually evaluate counters after job completes
Date Tue, 07 Jul 2015 19:43:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617250#comment-14617250
] 

Hadoop QA commented on HBASE-13561:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12743994/HBASE-13561-v2.patch
  against master branch at commit 7acb061e63614ad957da654f920f54ac7a02edd6.
  ATTACHMENT ID: 12743994

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.phoenix.mapreduce.IndexToolIT.testMutalbleIndexWithUpdates(IndexToolIT.java:228)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14696//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14696//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14696//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14696//console

This message is automatically generated.

> ITBLL.Verify doesn't actually evaluate counters after job completes
> -------------------------------------------------------------------
>
>                 Key: HBASE-13561
>                 URL: https://issues.apache.org/jira/browse/HBASE-13561
>             Project: HBase
>          Issue Type: Bug
>          Components: integration tests
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0, 0.98.12
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 2.0.0, 0.98.14, 1.1.2, 1.3.0, 1.2.1, 1.0.3
>
>         Attachments: HBASE-13561-v1.patch, HBASE-13561-v2.patch
>
>
> Was digging through ITBLL and noticed this oddity:
> The {{Verify}} Tool doesn't actually call {{Verify#verify(long)}} like the {{Loop}} Tool
does. Granted, it doesn't know the total number of KVs that were written given the current
arguments, it's not even checking to see if there things like UNDEFINED records found.
> It seems to me that {{Verify}} should really be doing *some* checking on the counters
like {{Loop}} does and not just leaving it up to the visual inspection of whomever launched
the task.
> Am I missing something?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message