hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13561) ITBLL.Verify doesn't actually evaluate counters after job completes
Date Tue, 07 Jul 2015 17:44:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617050#comment-14617050
] 

stack commented on HBASE-13561:
-------------------------------

I tried it... v1. Looks good.

{code}
...        
    org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Verify$Counts
                REFERENCED=499395826
                UNDEFINED=302087
                UNREFERENCED=302087
        File Input Format Counters
                Bytes Read=0
        File Output Format Counters
                Bytes Written=20746296
        undef
                \x00\x00$\xA6\x96W\x9F\xC5\x81\x83r\x5Co[;3=1
                \x00\x005\xBC\x06\x0D\xE4'\xDD\xA6l\xA0\xB1c6~=1
                \x00\x007\xB3\x0D^\x11\xF2\xC4\xD74\xAA\xC5!\xA8o=1
                \x00\x008 \xD3\xD6Z\xCD\xD0\xBC\x9C\xE7\x1F\xEE\x11.=1
                \x00\x00=+\xD2\xB4\x91h\xCFJ8`\xF8\x82\xA5\xE7=1
                \x00\x00S\xE1\xD5\xC5n\xB9Y\xA3\xB8\xB9`\xA1\xCF\xB9=1
                \x00\x00\x0D\xC3)\xCB\x85@t\x0E\x8EZ\xBAy6\x8E=1
                \x00\x00\x16\xFF\x8E\x94\x0F\xFC\x13\xC1m~\xB9\xA8!\x85=1
                \x00\x00\x82@Z\xB1N\x1B\xA05\xFB\xBC\xDB\xD0\x0D\x04=1
                \x00\x00\x96z\xB9\x18\xE5\x9B\xC7\x14\xB1\xA6\x0Bf\x1F\xE7=1
                \x00\x00\x98*U(\x8Fqi\x04\xD8A\x13\x0E8j=1
                \x00\x00\xA3\xD8\x0F\x02\x13\x06n5\xD45.Y\xB3\x81=1
                \x00\x00\xC4ItJ\x0BX\x9F\x8A\x0D\xB5\xDDn\xAE"=1
                \x00\x00\xEB\xA7\x902X\xB0\xDD\xE1\x17\x83\xAD\x0C\xD0\x9F=1
                \x00\x00a\xF2k6\xBC;\xDD)5\xB2\xAD\xA7\xBA(=1
                \x00\x00g\xBB\xF5\xD2\xBE\x9Dm\xE1L\x8F\xB1&\xAB/=1
                \x00\x00{\x8E\x12\xE0\x1Des!\xF3I\xC7}Zn=1
                \x00\x00}k\x89\xF8b\x970\xC0\x07Xu\xAF\xDA\xC5=1
                \x00\x01+\xBE+\x10/\x87\xA4\xB5\xF8aEDdU=1
                \x00\x01.8\x9FiBj\xD3\x8E6e\xCF\xEC\xF8\xC9=1
                \x00\x010F\xCB\x0B \xA3\x07\x0B\x8D^X\xC7\x5C\x5C=1
                \x00\x016\xB0\x17\xD9\xE2\xF6S\xE9v\xB4u\xDD\xBF}=1
                \x00\x01?\xB3\xB8\x88\x1A\xF4\xA4\xAF\xFA!\xA8\xA1\x93\x8B=1
                \x00\x01J{tXz\x92\xDAI1\x96\x98E\x0E\x97=1
                \x00\x01X\xB1[C]0\xEAP\x90\xDF\xBE\xD87\xBD=1
                \x00\x01\x07\x93\x88/c3h\xA2i\xBAs\xB8\xB9\x5C=1
                \x00\x01\x8C\xAB\xED+\x95\xD4\x07\x178\xA4m2\xCE*=1
                \x00\x01\xAFGX>\x0C<\xFBi\xEB\xA4\xCB\x0D\x9B\xA3=1
                \x00\x01\xD5i\xF3\x95\x8Bn\xFEx{\xEC\x13\xFE\xE5\xBB=1
                \x00\x01\xDC\xF1\xE3FXZ\xE9\x00\xB4i.\x01\xFD\xC1=1
                \x00\x01\xE5?\xB8eB\xDEM\x01\x90\xF3<\xC8\x04\xB0=1
                \x00\x01\xF0\xD1\x14\x1DK\xAB\xE6\xADZ\xBC\xE5y\x12o=1
                \x00\x01c\xD1`\x00\x871qK \xB0\x88z;\x86=1
                \x00\x02 \x1C\x0E\xF3\xBD\xCDSb3\xEB\x8E\xA7\xFAs=1
                \x00\x020\xFA\x1F4\xAD\xA2K\xF7\xC2\xF5\xD9=\x86\x84=1
                \x00\x02\x09\x00xb\x06\x0B\xFB\x89\xC9\xDF\xEB9\xB7\xC7=1
                \x00\x02\xFE\xC6o\x91z\x85\xA6\xC1\xA2\xFDH\x05EK=1
                \x00\x02{\x1F\xD9{5\x06\x06H\xC5ql\xB0\x93\xF8=1
                \x00\x03`\xC0\xD1\xA1)\x8B\x18\x99=|\xCAk\x88\x88=1
                \x00\x03es\xA0\xC9h\xEEd\xCFL\xDFB\x9A\x92C=1
        unref
                \x00\x00\x87\xFE\xFA\xFF`\xD7\x8B\x0D#\xD9\xE2\xEFy\x89=1
                \x00\x00\xC5_\x9F\xFC\xBB\x969\xBE%\x89\xAB\xC7\x94W=1
                \x00\x00\xEF\xB0\xFC\xFD\x025$\xF9\x14\xC48\xA95\x8A=1
                \x00\x00wb?<\xA1=\xEA\xDC\x19\xBD\xD6\xEC\x09\xEE=1
                \x00\x01RK\x86\x18|0\xB8\xE3\xA2C\xA1\x07\xA4\x0C=1
15/07/07 10:26:21 ERROR test.IntegrationTestBigLinkedList$Verify: Found an undefined node.
Undefined count=302087
[stack@c2020 ~]$
[stack@c2020 ~]$
[stack@c2020 ~]$
[stack@c2020 ~]$
[stack@c2020 ~]$
[stack@c2020 ~]$
[stack@c2020 ~]$
[stack@c2020 ~]$ echo $?
1
{code}

Let me commit [~elserj]

> ITBLL.Verify doesn't actually evaluate counters after job completes
> -------------------------------------------------------------------
>
>                 Key: HBASE-13561
>                 URL: https://issues.apache.org/jira/browse/HBASE-13561
>             Project: HBase
>          Issue Type: Bug
>          Components: integration tests
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0, 0.98.12
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 2.0.0, 0.98.14, 1.1.2, 1.3.0, 1.2.1, 1.0.3
>
>         Attachments: HBASE-13561-v1.patch, HBASE-13561-v2.patch
>
>
> Was digging through ITBLL and noticed this oddity:
> The {{Verify}} Tool doesn't actually call {{Verify#verify(long)}} like the {{Loop}} Tool
does. Granted, it doesn't know the total number of KVs that were written given the current
arguments, it's not even checking to see if there things like UNDEFINED records found.
> It seems to me that {{Verify}} should really be doing *some* checking on the counters
like {{Loop}} does and not just leaving it up to the visual inspection of whomever launched
the task.
> Am I missing something?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message