hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13561) ITBLL.Verify doesn't actually evaluate counters after job completes
Date Tue, 07 Jul 2015 17:05:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616987#comment-14616987
] 

Josh Elser commented on HBASE-13561:
------------------------------------

If you didn't get to it.. I deleted {{\x00\x02\x91\x1E\xA5U\x97\xC9x\xA0\xAE\xCD\xED*C\x92}},
then re-{{Verify}}ied.

{noformat}
	org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Verify$Counts
		REFERENCED=39999998
		UNDEFINED=1
		UNREFERENCED=1
	undef
		\x00\x02\x91\x1E\xA5U\x97\xC9x\xA0\xAE\xCD\xED*C\x92=1
	unref
		\xD7\xFE{~0\x1C\x91#\xA5\xE1\x01T\xA7UwY=1
2015-07-07 12:52:12,362 ERROR [main] test.IntegrationTestBigLinkedList$Verify: Found an undefined
node. Undefined count=1
% echo $?
1
{noformat}

I did notice that I could update the usage for ITBLL to be a bit more accurate after these
changes. Will put up a v2 shortly.

> ITBLL.Verify doesn't actually evaluate counters after job completes
> -------------------------------------------------------------------
>
>                 Key: HBASE-13561
>                 URL: https://issues.apache.org/jira/browse/HBASE-13561
>             Project: HBase
>          Issue Type: Bug
>          Components: integration tests
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0, 0.98.12
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 2.0.0, 0.98.14, 1.1.2, 1.3.0, 1.2.1, 1.0.3
>
>         Attachments: HBASE-13561-v1.patch
>
>
> Was digging through ITBLL and noticed this oddity:
> The {{Verify}} Tool doesn't actually call {{Verify#verify(long)}} like the {{Loop}} Tool
does. Granted, it doesn't know the total number of KVs that were written given the current
arguments, it's not even checking to see if there things like UNDEFINED records found.
> It seems to me that {{Verify}} should really be doing *some* checking on the counters
like {{Loop}} does and not just leaving it up to the visual inspection of whomever launched
the task.
> Am I missing something?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message