hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13387) Add ByteBufferedCell an extension to Cell
Date Tue, 07 Jul 2015 04:52:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616173#comment-14616173
] 

Anoop Sam John commented on HBASE-13387:
----------------------------------------

bq. but how about tests of the new methods added especially when backed by a BBCell?
I will add..  We are not having an impl for this right now.  Will create a test impl and add
tests.  In fact our local branch is having tests. My bad.. I forgot to get those into this
patch.
bq.Should ByteBufferedCell be in hbase-server module? Can it be in the RegionServer package?
(It doesn't look like it given we look for it in comparators. I suppose also BBCell doesn't
have to have anything to do with Server when in common module. Someone else might want to
use it for some other purpose?
I also wanted it to be in server and thought that way initially.  But we do need this ref
in classes like CellComparator, CellUtil etc which has to be in common module. As of now no
need to expose it outside of RS.  We have Private InterfaceAudience for this class.   Is this
ok? We do have some other similar classes also in common module where the class makes sense
only in RS. (like org.apache.hadoop.hbase.io.hfile package fully?)


> Add ByteBufferedCell an extension to Cell
> -----------------------------------------
>
>                 Key: HBASE-13387
>                 URL: https://issues.apache.org/jira/browse/HBASE-13387
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: ByteBufferedCell.docx, HBASE-13387_v1.patch, WIP_HBASE-13387_V2.patch,
WIP_ServerCell.patch, benchmark.zip
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added as a comment
on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ByteBufferedCell'  in which we can add new buffer
based getter APIs and getters for position in components in BB.  We will keep this interface
@InterfaceAudience.Private.   When the Cell is backed by a DBB, we can create an Object implementing
this new interface.
> The Comparators has to be aware abt this new Cell extension and has to use the BB based
APIs rather than getXXXArray().  Also give util APIs in CellUtil to abstract the checks for
new Cell type.  (Like matchingXXX APIs, getValueAs<type> APIs etc)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message