hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12296) Filters should work with ByteBufferedCell
Date Wed, 15 Jul 2015 12:03:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627944#comment-14627944
] 

Hadoop QA commented on HBASE-12296:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12745418/HBASE-12296_v1.patch
  against master branch at commit a63e3ac83ffb91948f464e4f62111d29adc02812.
  ATTACHMENT ID: 12745418

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 14 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1874 checkstyle
errors (more than the master's current 1873 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14780//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14780//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14780//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14780//console

This message is automatically generated.

> Filters should work with ByteBufferedCell
> -----------------------------------------
>
>                 Key: HBASE-12296
>                 URL: https://issues.apache.org/jira/browse/HBASE-12296
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12296_v1.patch, HBASE-12296_v1.patch
>
>
> Now we have added an extension for Cell in server side, ByteBufferedCell, where Cells
are backed by BB (on heap or off heap). When the Cell is backed by off heap buffer, the getXXXArray()
APIs has to create temp byte[] and do data copy and return that. This will be bit costly.
 We have avoided this in areas like CellComparator/SQM etc. Filter area was not touched in
that patch.  This Jira aims at doing it in Filter area. 
> Eg : SCVF checking the cell value for the given value condition. It uses getValueArray()
to get cell value bytes.  When the cell is BB backed, it has to use getValueByteBuffer() API
instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message