hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12296) Filters should work with ByteBufferedCell
Date Tue, 14 Jul 2015 18:04:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626782#comment-14626782
] 

ramkrishna.s.vasudevan commented on HBASE-12296:
------------------------------------------------

I understood the intent for moving to CellComparator but this comparator is some special thing?
Anyway no problem. Anyway is fine with me.
bq.So what you say is add this new abstract class and deprecated ByteArrayComparable in favor
of the new one ? Am ok with both ways.
Your call.  If we add an abstract class and deprecate this then in 3.0 we can remove the ByteArrayComparable
totally right? 

> Filters should work with ByteBufferedCell
> -----------------------------------------
>
>                 Key: HBASE-12296
>                 URL: https://issues.apache.org/jira/browse/HBASE-12296
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12296_v1.patch
>
>
> Now we have added an extension for Cell in server side, ByteBufferedCell, where Cells
are backed by BB (on heap or off heap). When the Cell is backed by off heap buffer, the getXXXArray()
APIs has to create temp byte[] and do data copy and return that. This will be bit costly.
 We have avoided this in areas like CellComparator/SQM etc. Filter area was not touched in
that patch.  This Jira aims at doing it in Filter area. 
> Eg : SCVF checking the cell value for the given value condition. It uses getValueArray()
to get cell value bytes.  When the cell is BB backed, it has to use getValueByteBuffer() API
instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message