Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 460BB185D3 for ; Tue, 30 Jun 2015 20:29:05 +0000 (UTC) Received: (qmail 10885 invoked by uid 500); 30 Jun 2015 20:29:05 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 10832 invoked by uid 500); 30 Jun 2015 20:29:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10819 invoked by uid 99); 30 Jun 2015 20:29:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2015 20:29:05 +0000 Date: Tue, 30 Jun 2015 20:29:05 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13965) Stochastic Load Balancer JMX Metrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13965?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D146= 09007#comment-14609007 ]=20 stack commented on HBASE-13965: ------------------------------- Thank you for the design and patch overview. Helps. The changes in your patch to hbase-env.sh are probably not intended. Ditto = hbase-site.xml... and others. Add license to new classes (see adjacent classes for how), javadoc on Inter= faces especially (no need of public qualifiers when an Interface), and see = annotations in accompanying classes and apply as appropriate here (mark the= m private I'd say). I wouldn't even bother offering DEFAULT vs STOCHASTIC. No one runs any bala= ncer but stochastic (Besides default is the Stochastic). Remove the choice= . Otherwise, patch looking good. Suggest you past example of what it looks li= ke when it is working. FYI [~eclark] > Stochastic Load Balancer JMX Metrics > ------------------------------------ > > Key: HBASE-13965 > URL: https://issues.apache.org/jira/browse/HBASE-13965 > Project: HBase > Issue Type: Improvement > Components: Balancer, metrics > Reporter: Lei Chen > Assignee: Lei Chen > Attachments: HBase-13965-v1.patch, stochasticloadbalancerclasses_= v2.png > > > Today=E2=80=99s default HBase load balancer (the Stochastic load balancer= ) is cost function based. The cost function weights are tunable but no visi= bility into those cost function results is directly provided. > A driving example is a cluster we have been tuning which has skewed rack = size (one rack has half the nodes of the other few racks). We are tuning th= e cluster for uniform response time from all region servers with the abilit= y to tolerate a rack failure. Balancing LocalityCost, RegionReplicaRack Cos= t and RegionCountSkew Cost is difficult without a way to attribute each cos= t function=E2=80=99s contribution to overall cost.=20 > What this jira proposes is to provide visibility via JMX into each cost f= unction of the stochastic load balancer, as well as the overall cost of the= balancing plan. -- This message was sent by Atlassian JIRA (v6.3.4#6332)