Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A36F181D4 for ; Mon, 15 Jun 2015 16:46:01 +0000 (UTC) Received: (qmail 95664 invoked by uid 500); 15 Jun 2015 16:46:01 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 95607 invoked by uid 500); 15 Jun 2015 16:46:01 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95595 invoked by uid 99); 15 Jun 2015 16:46:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jun 2015 16:46:01 +0000 Date: Mon, 15 Jun 2015 16:46:01 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-13894) Avoid visitor alloc each call of ByteBufferArray get/putMultiple() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-13894: ------------------------------------ Attachment: IdLockPerf.java HBASE-13903-v0.patch v0 is better in perf/contention that what we have currently, but is not the optimal solution. if we can get rid of that map and have a custom one we will avoid the double lock map + entry semaphore, and we can get rid of that while true with the deleted flag > Avoid visitor alloc each call of ByteBufferArray get/putMultiple() > ------------------------------------------------------------------ > > Key: HBASE-13894 > URL: https://issues.apache.org/jira/browse/HBASE-13894 > Project: HBase > Issue Type: Improvement > Components: regionserver > Affects Versions: 2.0.0, 1.0.1, 1.1.0 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.1.1 > > Attachments: HBASE-13894-v0.patch > > > ByteBufferArray getMultiple()/putMultiple() creates a new Visitor each call. we can move that visitor out. > also, ByteBufferArray.multiple() seems to be an hotspot, I tried to do some experiments using slice and read/write lock instead of a mutex, doesn't seems to change much. any thoughts? -- This message was sent by Atlassian JIRA (v6.3.4#6332)