Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73F5F18214 for ; Thu, 4 Jun 2015 04:19:39 +0000 (UTC) Received: (qmail 32584 invoked by uid 500); 4 Jun 2015 04:19:39 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 32516 invoked by uid 500); 4 Jun 2015 04:19:39 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 32290 invoked by uid 99); 4 Jun 2015 04:19:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2015 04:19:39 +0000 Date: Thu, 4 Jun 2015 04:19:39 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13835) KeyValueHeap.current might be in heap when exception happens in pollRealKV MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572093#comment-14572093 ] Hadoop QA commented on HBASE-13835: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12737437/HBASE-13835-001.patch against master branch at commit e8e5a9f6398f5a99f1d89be359212a7a4f1d7b05. ATTACHMENT ID: 12737437 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14277//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14277//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14277//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14277//console This message is automatically generated. > KeyValueHeap.current might be in heap when exception happens in pollRealKV > -------------------------------------------------------------------------- > > Key: HBASE-13835 > URL: https://issues.apache.org/jira/browse/HBASE-13835 > Project: HBase > Issue Type: Bug > Components: Scanners > Reporter: zhouyingchao > Assignee: zhouyingchao > Attachments: HBASE-13835-001.patch > > > In a 0.94 hbase cluster, we found a NPE with following stack: > {code} > Exception in thread "regionserver21600.leaseChecker" java.lang.NullPointerException > at org.apache.hadoop.hbase.KeyValue$KVComparator.compare(KeyValue.java:1530) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap$KVScannerComparator.compare(KeyValueHeap.java:225) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap$KVScannerComparator.compare(KeyValueHeap.java:201) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap$KVScannerComparator.compare(KeyValueHeap.java:191) > at java.util.PriorityQueue.siftDownUsingComparator(PriorityQueue.java:641) > at java.util.PriorityQueue.siftDown(PriorityQueue.java:612) > at java.util.PriorityQueue.poll(PriorityQueue.java:523) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap.close(KeyValueHeap.java:241) > at org.apache.hadoop.hbase.regionserver.StoreScanner.close(StoreScanner.java:355) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap.close(KeyValueHeap.java:237) > at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.close(HRegion.java:4302) > at org.apache.hadoop.hbase.regionserver.HRegionServer$ScannerListener.leaseExpired(HRegionServer.java:3033) > at org.apache.hadoop.hbase.regionserver.Leases.run(Leases.java:119) > at java.lang.Thread.run(Thread.java:662) > {code} > Before this NPE exception, there is an exception happens in pollRealKV, which we think is the culprit of the NPE. > {code} > ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: > java.io.IOException: Could not reseek StoreFileScanner[HFileScanner for reader reader=.... > at org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseek(StoreFileScanner.java:180) > at org.apache.hadoop.hbase.regionserver.StoreFileScanner.enforceSeek(StoreFileScanner.java:371) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap.pollRealKV(KeyValueHeap.java:366) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:116) > at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:455) > at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:154) > at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:4124) > at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:4196) > at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:4067) > at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:4057) > at org.apache.hadoop.hbase.regionserver.HRegionServer.internalNext(HRegionServer.java:2898) > at org.apache.hadoop.hbase.regionserver.HRegionServer.next(HRegionServer.java:2833) > at org.apache.hadoop.hbase.regionserver.HRegionServer.next(HRegionServer.java:2815) > at sun.reflect.GeneratedMethodAccessor38.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at org.apache.hadoop.hbase.ipc.SecureRpcEngine$Server.call(SecureRpcEngine.java:337) > at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1583) > {code} > Simply put, if there is an exception happens in pollRealKV( ), the KeyValueHeap.current might be in heap. Later on, when KeyValueHeap.close( ) is called, the current would be closed firstly. However, since it might still be in the heap, it would either be closed again or its peek() (which is null after it is closed) is called by the heap's poll(). Neither case is expected. > Although it is caught in 0.94, it is still in the trunk from the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)