Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6D5410C7E for ; Fri, 5 Jun 2015 12:46:05 +0000 (UTC) Received: (qmail 71202 invoked by uid 500); 5 Jun 2015 12:46:00 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 71146 invoked by uid 500); 5 Jun 2015 12:46:00 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 71135 invoked by uid 99); 5 Jun 2015 12:46:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 12:46:00 +0000 Date: Fri, 5 Jun 2015 12:46:00 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-13451) Make the HFileBlockIndex blockKeys to Cells so that it could be easy to use in the CellComparators MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-13451: ------------------------------------------- Attachment: HBASE-13451_3.patch Addresses review comments from Stack. Minor changes from the previous patches. [~saint.ack@gmail.com] Thanks for the review. I verified every method in the BlockIndexreader and they have sufficient coverage. TestHFile, TestHfileWriterV2 and V3, TestSeekTo, TestcompoundBloomFilter addresses the coverage part. Regarding changing the scope to package private, I doubt it cannot be done because the BlockIndexReader is used in CompoundBloomFilter used in util package. > Make the HFileBlockIndex blockKeys to Cells so that it could be easy to use in the CellComparators > -------------------------------------------------------------------------------------------------- > > Key: HBASE-13451 > URL: https://issues.apache.org/jira/browse/HBASE-13451 > Project: HBase > Issue Type: Sub-task > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-13451.patch, HBASE-13451_1.patch, HBASE-13451_2.patch, HBASE-13451_3.patch > > > After HBASE-10800 we could ensure that all the blockKeys in the BlockReader are converted to Cells (KeyOnlyKeyValue) so that we could use CellComparators. Note that this can be done only for the keys that are written using CellComparators and not for the ones using RawBytesComparator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)