hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14001) Optimize write(OutputStream out, boolean withTags) for SizeCachedNoTagsKeyValue
Date Tue, 30 Jun 2015 17:04:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608663#comment-14608663
] 

ramkrishna.s.vasudevan commented on HBASE-14001:
------------------------------------------------

LGTM.  
{code}
  public long heapSizeWithoutTags() {
43	    return super.heapSize();
44	  }
{code}
Is the above thing right?  Should it be super.heapSizeWithoutTags?  I noticed this in one
of my patches.  If this needs to be changed you can change it as part of this JIRA only.

> Optimize write(OutputStream out, boolean withTags) for SizeCachedNoTagsKeyValue
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-14001
>                 URL: https://issues.apache.org/jira/browse/HBASE-14001
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Minor
>         Attachments: HBASE-14001.patch
>
>
> We can override this method in SizeCachedNoTagsKeyValue.  KeyValue impl do value length
parsing and do some maths to find length with out tags length.  In SizeCachedNoTagsKeyValue
we know there are no tags.  Same optimize we did in NoTagsKeyValue.  But I missed to do it
in SizeCachedNoTagsKeyValue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message