hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13998) Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength)
Date Tue, 30 Jun 2015 12:37:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608219#comment-14608219
] 

Hadoop QA commented on HBASE-13998:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12742775/HBASE-13998.patch
  against master branch at commit f8bd578b80b4e656d799c82ca1b6191e35bb0ae4.
  ATTACHMENT ID: 12742775

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14617//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14617//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14617//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14617//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14617//console

This message is automatically generated.

> Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right,
int roffset, int rlength)
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13998
>                 URL: https://issues.apache.org/jira/browse/HBASE-13998
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13998.patch
>
>
> A public API in CellComparator which takes old style byte[], offset, length alone is
not correct.  CellComparator supposed to compare cell(s).  At least one side param has to
be a cell.. This is the agreement we discussed in HBASE-10800.  Still we could not remove
the above one method because it was getting used from multiple places.  Now most of the usage
is removed.  This jira aims at removing it fully and replace the usage with other APIs.
> Note: The CellComparator is added in 2.0 only so removing the public API is not creating
any BC issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message