hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13995) ServerName is not fully case insensitive
Date Tue, 30 Jun 2015 16:25:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608609#comment-14608609

Hadoop QA commented on HBASE-13995:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit f8bd578b80b4e656d799c82ca1b6191e35bb0ae4.
  ATTACHMENT ID: 12742861

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14626//console

This message is automatically generated.

> ServerName is not fully case insensitive
> ----------------------------------------
>                 Key: HBASE-13995
>                 URL: https://issues.apache.org/jira/browse/HBASE-13995
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 2.0.0, 1.2.0,,,
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
>         Attachments: HBASE-13995-v0.patch, HBASE-13995-v0.patch
> we ended up with two ServerName with different cases, AAA and aaa.
> Trying to create a table, every once in a while, we ended up with the region lost and
not assigned. 
> BaseLoadBalancer.roundRobinAssignment() goes through each server and create a map with
what to assign to them.
> We had to server on the list AAA and aaa which are the same machine, the problem is that
the round robin now is assigning an empty list to one of the two. so depending on the order
we ended up with a region not assigned.
> ServerName equals() does the case insensitive comparison but the hashCode() is done on
a case sensitive server name, so the Map in ServerManager will never hit the item and compare
it using equals, so we end up with two entries that are the same server. similar thing for
ServerName.isSameHostnameAndPort() where we don't check for cases

This message was sent by Atlassian JIRA

View raw message