hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apekshit Sharma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13981) Fix ImportTsv spelling and usage issues
Date Mon, 29 Jun 2015 18:22:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606060#comment-14606060
] 

Apekshit Sharma commented on HBASE-13981:
-----------------------------------------

While you are at it, maybe fix that whole block of code because there are lots of style issues
in there. One or two are easy to ignore, but so many are just eyesore! It's fine if you can't
right now, in which case feel free to create a new jira and assign it to me.

1) Weird new line after 'be'
{code}
"input data. Another special column " + TsvParser.TIMESTAMPKEY_COLUMN_SPEC +
" designates that this column should be\n" +
"used as timestamp for each record. Unlike " + TsvParser.ROWKEY_COLUMN_SPEC + ", " +
{code}

In fact, it feels like '\n' has been overused by added to the end of each line. Probably only
use it when paragraph break is required?

2) Inconsistent spaces: Sometimes there are spaces around '+' and sometimes not. Adding spaces
everywhere would be good idea.

3) wrong alignment
{code}
" Attributes should be specified as key"+ImportTsv.DEFAULT_ATTRIBUTES_SEPARATOR+"value where
"+
             ImportTsv.DEFAULT_MULTIPLE_ATTRIBUTES_SEPARATOR+
" is used as the separator. Note that more than one Operation Attributes can be specified.\n"+
{code}


> Fix ImportTsv spelling and usage issues
> ---------------------------------------
>
>                 Key: HBASE-13981
>                 URL: https://issues.apache.org/jira/browse/HBASE-13981
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 1.1.0.1
>            Reporter: Lars George
>            Assignee: Gabor Liptak
>              Labels: beginner
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-13981.1.patch
>
>
> The {{ImportTsv}} tool has various spelling and formatting issues. Fix those.
> In code:
> {noformat}
>   public final static String ATTRIBUTE_SEPERATOR_CONF_KEY = "attributes.seperator";
> {noformat}
> It is "separator".
> In usage text:
> {noformat}
> "input data. Another special columnHBASE_TS_KEY designates that this column should be"
> {noformat}
> Space missing.
> {noformat}
> "Record with invalid timestamps (blank, non-numeric) will be treated as bad record."
> {noformat}
> "Records ... as bad records" - plural missing twice.
> {noformat}
> "HBASE_ATTRIBUTES_KEY can be used to specify Operation Attributes per record.
>  Should be specified as key=>value where -1 is used 
>  as the seperator.  Note that more than one OperationAttributes can be specified."
> {noformat}
> - Remove line wraps and indentation. 
> - Fix "separator".
> - Fix wrong separator being output, it is not "-1" (wrong constant use in code)
> - General wording/style could be better (eg. last sentence now uses OperationAttributes
without a space).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message