hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13978) Variable never assigned in SimpleTotalOrderPartitioner.getPartition()
Date Tue, 30 Jun 2015 04:57:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607493#comment-14607493
] 

ramkrishna.s.vasudevan commented on HBASE-13978:
------------------------------------------------

+1 on the patch. I have not used this partitioner but the patch makes sense.

> Variable never assigned in SimpleTotalOrderPartitioner.getPartition() 
> ----------------------------------------------------------------------
>
>                 Key: HBASE-13978
>                 URL: https://issues.apache.org/jira/browse/HBASE-13978
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 1.1.0.1
>            Reporter: Lars George
>            Assignee: Bhupendra Kumar Jain
>              Labels: beginner
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: 0001-HBASE-13978-Variable-never-assigned-in-SimpleTotalOr.patch
>
>
> See https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/SimpleTotalOrderPartitioner.java#L104,
which has an {{if}} statement that tries to limit the code to run only once, but since it
does not assign {{this.lastReduces}} it will always trigger and recompute the splits (and
log them).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message