hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13974) TestRateLimiter#testFixedIntervalResourceAvailability may fail
Date Fri, 26 Jun 2015 13:40:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602884#comment-14602884

Hadoop QA commented on HBASE-13974:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit 2ed058554c0b6d6da0388497562e254107f13d67.
  ATTACHMENT ID: 12742020

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14583//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14583//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14583//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14583//console

This message is automatically generated.

> TestRateLimiter#testFixedIntervalResourceAvailability may fail
> --------------------------------------------------------------
>                 Key: HBASE-13974
>                 URL: https://issues.apache.org/jira/browse/HBASE-13974
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-13974.patch
> Stacktrace
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:86)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertFalse(Assert.java:64)
> 	at org.junit.Assert.assertFalse(Assert.java:74)
> 	at org.apache.hadoop.hbase.quotas.TestRateLimiter.testFixedIntervalResourceAvailability(TestRateLimiter.java:151)
> The code of this ut.
> {code}
>      RateLimiter limiter = new FixedIntervalRateLimiter();
>      limiter.set(10, TimeUnit.MILLISECONDS);
>      assertTrue(limiter.canExecute(10));
>      limiter.consume(3);
>      assertEquals(7, limiter.getAvailable());
>      assertFalse(limiter.canExecute(10));
> {code}
> The limiter will refill by MILLISECONDS. So if this unit test execute slowly or hang
by others over 1 ms, the assertFalse(limiter.canExecute(10)) will fail.

This message was sent by Atlassian JIRA

View raw message