hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13943) Get rid of KeyValue#heapSizeWithoutTags
Date Tue, 30 Jun 2015 17:32:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608711#comment-14608711

Hadoop QA commented on HBASE-13943:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit f8bd578b80b4e656d799c82ca1b6191e35bb0ae4.
  ATTACHMENT ID: 12742844

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14625//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14625//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14625//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14625//console

This message is automatically generated.

> Get rid of KeyValue#heapSizeWithoutTags
> ---------------------------------------
>                 Key: HBASE-13943
>                 URL: https://issues.apache.org/jira/browse/HBASE-13943
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>         Attachments: HBASE-13943.patch
> {code}
> /**
>    * This is a hack that should be removed once we don't care about matching
>    * up client- and server-side estimations of cell size. It needed to be
>    * backwards compatible with estimations done by older clients. We need to
>    * pretend that tags never exist and cells aren't serialized with tag
>    * length included. See HBASE-13262 and HBASE-13303
>    */
>   @Deprecated
>   public static long estimatedHeapSizeOfWithoutTags(final Cell cell) {
>  {code}
>  We can avoid this for 2.0

This message was sent by Atlassian JIRA

View raw message