hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13939) Make HFileReaderImpl.getFirstKeyInBlock() to return a Cell
Date Tue, 30 Jun 2015 10:49:04 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anoop Sam John updated HBASE-13939:
-----------------------------------
    Fix Version/s:     (was: 1.1.2)

> Make HFileReaderImpl.getFirstKeyInBlock() to return a Cell
> ----------------------------------------------------------
>
>                 Key: HBASE-13939
>                 URL: https://issues.apache.org/jira/browse/HBASE-13939
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13939.patch, HBASE-13939_1.patch, HBASE-13939_2.patch, HBASE-13939_3.patch,
HBASE-13939_3.patch, HBASE-13939_branch-1.1.patch
>
>
> The getFirstKeyInBlock() in HFileReaderImpl is returning a BB. It is getting used in
seekBefore cases.  Because we return a BB we create a KeyOnlyKV once for comparison
> {code}
>       if (reader.getComparator()
>           .compareKeyIgnoresMvcc(
>               new KeyValue.KeyOnlyKeyValue(firstKey.array(), firstKey.arrayOffset(),
>                   firstKey.limit()), key) >= 0) {
>         long previousBlockOffset = seekToBlock.getPrevBlockOffset();
>         // The key we are interested in
>         if (previousBlockOffset == -1) {
>           // we have a 'problem', the key we want is the first of the file.
>           return false;
>         }
> ........
> {code}
> And if the compare fails we again create another KeyOnlyKv 
> {code}
>       Cell firstKeyInCurrentBlock = new KeyValue.KeyOnlyKeyValue(Bytes.getBytes(firstKey));
>       loadBlockAndSeekToKey(seekToBlock, firstKeyInCurrentBlock, true, key, true);
> {code}
> So one object will be enough and that can be returned by getFirstKeyInBlock. Also will
be useful when we go with Buffered backed server cell to change in one place. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message