hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13939) Make HFileReaderImpl.getFirstKeyInBlock() to return a Cell
Date Mon, 22 Jun 2015 10:13:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595711#comment-14595711

Hadoop QA commented on HBASE-13939:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit f9b17bfd37624374904ec15b9b1300fe4ae0d8c7.
  ATTACHMENT ID: 12740963

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 8 new or modified

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1943 checkstyle
errors (more than the master's current 1942 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14496//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14496//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14496//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14496//console

This message is automatically generated.

> Make HFileReaderImpl.getFirstKeyInBlock() to return a Cell
> ----------------------------------------------------------
>                 Key: HBASE-13939
>                 URL: https://issues.apache.org/jira/browse/HBASE-13939
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0, 1.1.1
>         Attachments: HBASE-13939.patch, HBASE-13939_1.patch, HBASE-13939_2.patch, HBASE-13939_branch-1.1.patch
> The getFirstKeyInBlock() in HFileReaderImpl is returning a BB. It is getting used in
seekBefore cases.  Because we return a BB we create a KeyOnlyKV once for comparison
> {code}
>       if (reader.getComparator()
>           .compareKeyIgnoresMvcc(
>               new KeyValue.KeyOnlyKeyValue(firstKey.array(), firstKey.arrayOffset(),
>                   firstKey.limit()), key) >= 0) {
>         long previousBlockOffset = seekToBlock.getPrevBlockOffset();
>         // The key we are interested in
>         if (previousBlockOffset == -1) {
>           // we have a 'problem', the key we want is the first of the file.
>           return false;
>         }
> ........
> {code}
> And if the compare fails we again create another KeyOnlyKv 
> {code}
>       Cell firstKeyInCurrentBlock = new KeyValue.KeyOnlyKeyValue(Bytes.getBytes(firstKey));
>       loadBlockAndSeekToKey(seekToBlock, firstKeyInCurrentBlock, true, key, true);
> {code}
> So one object will be enough and that can be returned by getFirstKeyInBlock. Also will
be useful when we go with Buffered backed server cell to change in one place. 

This message was sent by Atlassian JIRA

View raw message