hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13937) Partially revert HBASE-13172
Date Sat, 20 Jun 2015 04:15:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594386#comment-14594386

Hadoop QA commented on HBASE-13937:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against master branch at commit db08013ebeeaa85802d9795cc72b4c29c5338a47.
  ATTACHMENT ID: 12740771

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14480//console

This message is automatically generated.

> Partially revert HBASE-13172 
> -----------------------------
>                 Key: HBASE-13937
>                 URL: https://issues.apache.org/jira/browse/HBASE-13937
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Region Assignment
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.14, 1.2.0, 1.1.1, 1.3.0
>         Attachments: hbase-13937_v1.patch, hbase-13937_v2.patch, hbase-13937_v3.patch,
> HBASE-13172 is supposed to fix a UT issue, but causes other problems that parent jira
(HBASE-13605) is attempting to fix. 
> However, HBASE-13605 patch v4 uncovers at least 2 different issues which are, to put
it mildly, major design flaws in AM / RS. 
> Regardless of 13605, the issue with 13172 is that we catch {{ServerNotRunningYetException}}
from {{isServerReachable()}} and return false, which then puts the Server to the {{RegionStates.deadServers}}
list. Once it is in that list, we can still assign and unassign regions to the RS after it
has started (because regular assignment does not check whether the server is in  {{RegionStates.deadServers}}.
However, after the first assign and unassign, we cannot assign the region again since then
the check for the lastServer will think that the server is dead. 
> It turns out that a proper patch for 13605 is very hard without fixing rest of  broken
AM assumptions (see HBASE-13605, HBASE-13877 and HBASE-13895 for a colorful history). For
1.1.1, I think we should just revert parts of HBASE-13172 for now. 

This message was sent by Atlassian JIRA

View raw message