hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13933) DBE's seekBefore with tags corrupts the tag's offset information thus leading to incorrect results
Date Thu, 18 Jun 2015 14:33:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591888#comment-14591888
] 

Anoop Sam John commented on HBASE-13933:
----------------------------------------

Debugging with the test case change u suggested, seems this is the issue..  With below change
the test passes
{code}
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
@@ -197,6 +197,7 @@ abstract class BufferedDataBlockEncoder implements DataBlockEncoder {
       if (nextState.tagCompressionContext != null) {
         tagCompressionContext = nextState.tagCompressionContext;
       }
+      tagsOffset = nextState.tagsOffset;
     }
{code}
Any thing else missing ?

> DBE's seekBefore with tags corrupts the tag's offset information thus leading to incorrect
results
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13933
>                 URL: https://issues.apache.org/jira/browse/HBASE-13933
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0, 1.0.1, 1.1.0, 0.98.13, 1.0.1.1, 1.1.0.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>         Attachments: HBASE-13933.patch
>
>
> The problem occurs with moveToPrevious() case and incase of tags we copy the previous
pointer's tag info to the current because already decoded the tags.
> Will check once again before I post other details.  I have a test case to reproduce the
problem. Found this while working with MultibyteBuffers and verified if this is present in
trunk - it is in all branches where we have tags compression (I suppose) will verify



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message