hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13916) Create MultiByteBuffer
Date Wed, 17 Jun 2015 11:20:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589644#comment-14589644

Anoop Sam John commented on HBASE-13916:

I have increased the ok count for javadoc by 1. Not sure whether this is enough or not for
the new Unsafe code added in ByteBufferUtils. Other javadoc comments I have already fixed.
If any more to add, I will change on commit.
bq.Was just asking what you thought. Leave as is if you think that best.
I am agreeing with you Stack. Moved to suggested new package.
bq.Why a getVLong in here? That belongs outside this class?
Moved to ByteBufferUtils now.
Thanks Stack. Will commit as per QA run result

> Create MultiByteBuffer
> ----------------------
>                 Key: HBASE-13916
>                 URL: https://issues.apache.org/jira/browse/HBASE-13916
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>         Attachments: HBASE-13916.patch, HBASE-13916_V2.patch, HBASE-13916_V3.patch
> This is an aggregation of N ByteBuffers. The block when served directly by block cache
buckets memory, we have the block data split across multiple byte buffers. This aggregate
type (like ByteBuffer) will serve the HFileBlock data.
> This jira wil just provide the new data structure

This message was sent by Atlassian JIRA

View raw message