hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Liptak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13900) duplicate methods between ProtobufMagic and ProtobufUtil
Date Mon, 15 Jun 2015 23:58:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587173#comment-14587173
] 

Gabor Liptak commented on HBASE-13900:
--------------------------------------

Yes, I will provide a patch

> duplicate methods between ProtobufMagic and ProtobufUtil
> --------------------------------------------------------
>
>                 Key: HBASE-13900
>                 URL: https://issues.apache.org/jira/browse/HBASE-13900
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Gabor Liptak
>            Priority: Minor
>
> Several methods duplicated between:
> hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java
> and
> hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
> isPBMagicPrefix()
> isPBMagicPrefix()
> lengthOfPBMagic()
> ProtobufUtil partically references ProtobufMagic, but it also has different compare implementation
...
> Maybe this was based on packaging/signature need?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message