hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13898) correct additional javadoc failures under java 8
Date Mon, 22 Jun 2015 00:53:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595268#comment-14595268
] 

Hadoop QA commented on HBASE-13898:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12740936/HBASE-13921.2.patch
  against master branch at commit e4d8fab104d6c4edc8721ee14238fcc59bd203d0.
  ATTACHMENT ID: 12740936

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation patch
that doesn't require tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1942 checkstyle
errors (more than the master's current 1906 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED",
+        for (ClientProtos.MutationProto.ColumnValue.QualifierValue qv: column.getQualifierValueList())
{
+  public static Delete toDelete(final ClientProtos.MutationProto proto, final CellScanner
cellScanner)
+                  new Delete(cell.getRowArray(), cell.getRowOffset(), cell.getRowLength(),
timestamp);
+        for (ClientProtos.MutationProto.ColumnValue.QualifierValue qv: column.getQualifierValueList())
{
+  public static Append toAppend(final ClientProtos.MutationProto proto, final CellScanner
cellScanner)
+        for (ClientProtos.MutationProto.ColumnValue.QualifierValue qv: column.getQualifierValueList())
{
+  public static Increment toIncrement(final ClientProtos.MutationProto proto, final CellScanner
cellScanner)
+        for (ClientProtos.MutationProto.ColumnValue.QualifierValue qv: column.getQualifierValueList())
{
+    ClientProtos.MutationProto.ColumnValue.Builder columnBuilder = ClientProtos.MutationProto.ColumnValue.newBuilder();

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14493//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14493//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14493//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14493//console

This message is automatically generated.

> correct additional javadoc failures under java 8
> ------------------------------------------------
>
>                 Key: HBASE-13898
>                 URL: https://issues.apache.org/jira/browse/HBASE-13898
>             Project: HBase
>          Issue Type: Sub-task
>          Components: documentation
>    Affects Versions: 1.2.0
>            Reporter: Sean Busbey
>            Assignee: Gabor Liptak
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-13898-amendment.1.patch, HBASE-13898.1.patch, HBASE-13921.2.patch
>
>
> Java 8's javadoc gives an error where previous javadoc tools gave a more lenient WARN.
HBASE-13569 took down the majority of the gaps, but while that issue was in review we gained
some more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message